[webkit-reviews] review granted: [Bug 173062] Laili restaurant menu page does not display full menu in Safari (works in Chrome and Firefox) : [Attachment 312193] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 173062: Laili restaurant menu page does not display full menu in Safari
(works in Chrome and Firefox)
https://bugs.webkit.org/show_bug.cgi?id=173062

Attachment 312193: Patch

https://bugs.webkit.org/attachment.cgi?id=312193&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312193
  --> https://bugs.webkit.org/attachment.cgi?id=312193
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312193&action=review

> Source/WebCore/ChangeLog:9
> +	   Added fast/replaced/max-height-percent-inside-auto-block.html

Usually this is like:
	Test: fast/replaced/max-height-percent-inside-auto-block.html

and comes after the comment. prepare-ChangeLog does this for you.

> Source/WebCore/rendering/RenderBox.cpp:3155
> +    if (!replacedMinMaxLogicalHeightComputesAsNone(MinSize))
> +	   minLogicalHeight = computeReplacedLogicalHeightUsing(MinSize,
style().logicalMinHeight());
> +    LayoutUnit maxLogicalHeight = logicalHeight;
> +    if (!replacedMinMaxLogicalHeightComputesAsNone(MaxSize))
> +	   maxLogicalHeight = computeReplacedLogicalHeightUsing(MaxSize,
style().logicalMaxHeight());

Seems like we'll call containingBlockForAutoHeightDetection() twice via this
coe and usually find the same containingBlock? Can we optimize to call it only
once?

> Source/WebCore/rendering/RenderBox.h:671
> +    bool replacedMinMaxLogicalHeightComputesAsNone(SizeType sizeType) const;

You can remove the parameter name (style bot will probably tell you).