[webkit-reviews] review granted: [Bug 173045] Add WebRTC stats logging : [Attachment 312185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 7 08:36:16 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 173045: Add WebRTC stats logging
https://bugs.webkit.org/show_bug.cgi?id=173045
Attachment 312185: Patch
https://bugs.webkit.org/attachment.cgi?id=312185&action=review
--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 312185
--> https://bugs.webkit.org/attachment.cgi?id=312185
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312185&action=review
> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1005
> + if (!m_statsTimestamp)
> + m_statsTimestamp = report->timestamp_us();
> + else if (m_statsLogTimer.repeatInterval() == 1_s &&
(report->timestamp_us() - m_statsTimestamp) > 30000000) {
> + callOnMainThread([protectedThis = makeRef(*this)] {
> + protectedThis->m_statsLogTimer.augmentRepeatInterval(4_s);
> + });
> + }
Is there any reason to do this when RELEASE_LOG_DISABLED is defined?
More information about the webkit-reviews
mailing list