[webkit-reviews] review granted: [Bug 173050] [GTK][WPE][GSTREAMER_GL] Change the colorspace used by the video frames provided by GStreamer : [Attachment 312176] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 7 07:13:35 PDT 2017
Zan Dobersek <zan at falconsigh.net> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 173050: [GTK][WPE][GSTREAMER_GL] Change the colorspace used by the video
frames provided by GStreamer
https://bugs.webkit.org/show_bug.cgi?id=173050
Attachment 312176: Patch
https://bugs.webkit.org/attachment.cgi?id=312176&action=review
--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 312176
--> https://bugs.webkit.org/attachment.cgi?id=312176
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312176&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
53
> +#define TEXTUREMAPPER_COLORCONVERT_FLAG
TextureMapperGL::ShouldConvertTextureBGRAToRGBA
> +#define TEXTURECOPIER_COLORCONVERT_FLAG
VideoTextureCopierGStreamer::ColorConversion::ConvertBGRAToRGBA
These are hard to process IMO. TEXTURE_MAPPER_COLOR_CONVERT_FLAG and
TEXTURE_COPIER_COLOR_CONVERT_FLAG are fine.
More information about the webkit-reviews
mailing list