[webkit-reviews] review denied: [Bug 171790] AX: Video/Audio Player Controls missing group container. : [Attachment 312139] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has denied  review:
Bug 171790: AX: Video/Audio Player Controls missing group container.
https://bugs.webkit.org/show_bug.cgi?id=171790

Attachment 312139: Patch

https://bugs.webkit.org/attachment.cgi?id=312139&action=review




--- Comment #7 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 312139
  --> https://bugs.webkit.org/attachment.cgi?id=312139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312139&action=review

> Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:64
> +    set isAudio(value)

There already is a "shouldUseAudioLayout" property defined on
InlineMediaControls, which is set from AudioSupport. We should promote it to
MediaControls and augment it to perform the work you're doing here.