[webkit-reviews] review granted: [Bug 173044] [iOS WK1 WebThread] Do not call out to the main thread for device orientation. : [Attachment 312155] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted zalan <zalan at apple.com>'s request
for review:
Bug 173044: [iOS WK1 WebThread] Do not call out to the main thread for device
orientation.
https://bugs.webkit.org/show_bug.cgi?id=173044

Attachment 312155: Patch

https://bugs.webkit.org/attachment.cgi?id=312155&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 312155
  --> https://bugs.webkit.org/attachment.cgi?id=312155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312155&action=review

> Source/WebKit/ios/ChangeLog:12
> +	   This patch ensures that we don't call out to the main tread from the
Document's constructor.

s/tread/thread/

> Source/WebKit/mac/WebView/WebFrame.mm:1290
> +    WebView *webView = getWebView(self);
> +    [webView _setDeviceOrientation:[[webView _UIKitDelegateForwarder]
deviceOrientation]];

Is it really OK to set this here if the getter is called on the web thread?
should this be inside the WebThreadRun below?