[webkit-reviews] review granted: [Bug 173036] Update the design of the WebKit Feature Status page : [Attachment 312126] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jon Davis
<jond at apple.com>'s request for review:
Bug 173036: Update the design of the WebKit Feature Status page
https://bugs.webkit.org/show_bug.cgi?id=173036

Attachment 312126: Patch

https://bugs.webkit.org/attachment.cgi?id=312126&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312126
  --> https://bugs.webkit.org/attachment.cgi?id=312126
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312126&action=review

> Websites/webkit.org/wp-content/themes/webkit/status.php:573
> +	       console.log(specification);

Probably don't want this log here.

> Websites/webkit.org/wp-content/themes/webkit/status.php:629
> +		   link.href = "#feature-" +
feature.name.toLowerCase().replace(/ /g, '-');

How does navigating to this link interact with search?

> Websites/webkit.org/wp-content/themes/webkit/status.php:641
> +	       moreInfoList.className = 'moreinfo'

semicolon at the end

> Websites/webkit.org/wp-content/themes/webkit/status.php:654
> +		   li.className = "contact"

semicolon

> Websites/webkit.org/wp-content/themes/webkit/status.php:739
> +	       label.className = "filter-status " + statusId

semicolon

> Websites/webkit.org/wp-content/themes/webkit/status.php:802
> +	   //updateSpecsState();

Remove commented code.

> Websites/webkit.org/wp-content/themes/webkit/status.php:857
> +	   
> +	   

Blank lines.