[webkit-reviews] review granted: [Bug 172997] Cut down use of WTF_ARRAY_LENGTH : [Attachment 312111] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 6 14:57:43 PDT 2017
Chris Dumez <cdumez at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 172997: Cut down use of WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=172997
Attachment 312111: Patch
https://bugs.webkit.org/attachment.cgi?id=312111&action=review
--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 312111
--> https://bugs.webkit.org/attachment.cgi?id=312111
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312111&action=review
r=me
> Source/WTF/ChangeLog:12
> + equalLettersIgnoringASCIICase insetad of strncasecmp.
Typo: instead
> Source/WebCore/platform/graphics/FontCascade.cpp:540
> + return !fontFamiliesWithInvalidCharWidthMap.get().contains(family);
Personally preferred the old ->
More information about the webkit-reviews
mailing list