[webkit-reviews] review denied: [Bug 173003] [Win] Link errors on tag WebKit-603.3.4 : [Attachment 312086] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 173003: [Win] Link errors on tag WebKit-603.3.4
https://bugs.webkit.org/show_bug.cgi?id=173003

Attachment 312086: Patch

https://bugs.webkit.org/attachment.cgi?id=312086&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 312086
  --> https://bugs.webkit.org/attachment.cgi?id=312086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312086&action=review

r=me, but please figure out why the patch won't apply. :-)

> Source/WebKit/win/ChangeLog:10
> +	   on trunk.

Hold on! This will break any existing clients that have linkage that knows
about 'allowsPageCacheWithWindowOpener' and
'setAllowsPageCacheWithWindowOpener'. This shouldn't have been removed in
Trunk. Instead, these should be No-op stubs.

Can you please make that change in trunk and we can make sure that correct
change is merged back to 603 branch?