[webkit-reviews] review granted: [Bug 173008] [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting : [Attachment 312087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 6 10:51:37 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 173008: [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport
setting
https://bugs.webkit.org/show_bug.cgi?id=173008

Attachment 312087: Patch

https://bugs.webkit.org/attachment.cgi?id=312087&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 312087
  --> https://bugs.webkit.org/attachment.cgi?id=312087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312087&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:3089
> +- (NSString *)mediaUserGestureInheritsFromDocument

"mediaUserGestureInheritsFromDocument" - copy/pasta?

> Source/WebKit/mac/WebView/WebPreferences.mm:3094
> +- (void)setMediaUserGestureInheritsFromDocument:(NSString *)value

"setMediaUserGestureInheritsFromDocument" - copy/pasta?


More information about the webkit-reviews mailing list