[webkit-reviews] review granted: [Bug 172981] Add an option to disable getUserMedia prompt in case of mock capture sources : [Attachment 312075] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 172981: Add an option to disable getUserMedia prompt in case of mock
capture sources
https://bugs.webkit.org/show_bug.cgi?id=172981

Attachment 312075: Patch

https://bugs.webkit.org/attachment.cgi?id=312075&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 312075
  --> https://bugs.webkit.org/attachment.cgi?id=312075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312075&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:214
> +	       // FIXME: We should probably only allow this if page is already
actively capturing or page is visible.
> +	       // If page is hidden and not capturing, we should wait for page
to be visible before allowing the request.

This should have a bug number.