[webkit-reviews] review denied: [Bug 172944] OMG tier up checks should be a patchpoint : [Attachment 312039] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 172944: OMG tier up checks should be a patchpoint
https://bugs.webkit.org/show_bug.cgi?id=172944

Attachment 312039: Patch

https://bugs.webkit.org/attachment.cgi?id=312039&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 312039
  --> https://bugs.webkit.org/attachment.cgi?id=312039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312039&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:913
> +	       MacroAssembler::Call call = jit.nearCall();
> +
> +	       ScratchRegisterAllocator::restoreRegistersFromStackForCall(jit,
registersToSpill, RegisterSet(), numberOfStackBytesUsedForRegisterPreservation,
extraPaddingBytes);

This code looks wrong. You're not restoring SP after the call. Are tests
passing? I'm also looking at our other wasm call code, and wondering how any of
it works since none of it restores SP.

> Source/JavaScriptCore/wasm/WasmThunks.cpp:120
> +    jit.call(GPRInfo::argumentGPR2);

ditto