[webkit-reviews] review granted: [Bug 172943] ASSERTION FAILED: RunLoop::isMain() in com.apple.WebKit: IPC::Connection::sendSyncMessage + 128 : [Attachment 312041] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 172943: ASSERTION FAILED: RunLoop::isMain() in com.apple.WebKit:
IPC::Connection::sendSyncMessage + 128
https://bugs.webkit.org/show_bug.cgi?id=172943

Attachment 312041: Patch

https://bugs.webkit.org/attachment.cgi?id=312041&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 312041
  --> https://bugs.webkit.org/attachment.cgi?id=312041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312041&action=review

>
LayoutTests/storage/domstorage/sessionstorage/set-item-synchronous-keydown.html
:12
> +    sessionStorage.testValue = 1;

Oh, won't this persist to other tests? Should have a unique name like
setItemSynchronousKeydownTestValue (removing it at the end would be useful
too).