[webkit-reviews] review granted: [Bug 172787] Allow clients to specify a list of codecs which should require hardware decode support. : [Attachment 312022] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 5 13:07:03 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 172787: Allow clients to specify a list of codecs which should require
hardware decode support.
https://bugs.webkit.org/show_bug.cgi?id=172787

Attachment 312022: Patch

https://bugs.webkit.org/attachment.cgi?id=312022&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312022
  --> https://bugs.webkit.org/attachment.cgi?id=312022
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312022&action=review

> Source/WTF/ChangeLog:9
> +	   - a String::split() that returns a vector (rather than taking an
out-reference to a vector).

We should remove the old one in another patch.

> Source/WebCore/platform/graphics/FourCC.cpp:33
> +    auto asciiValue = stringValue.ascii();

Can this be used to represent bytes outside the range 0..127?

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:436
> +	   if (!assetTrackMeetsHardwareDecodeRequirements(track, {'hvc1'})) {

Apparently initializer list to const Vector& doesn't work on at least El
Capitan.


More information about the webkit-reviews mailing list