[webkit-reviews] review granted: [Bug 172928] webkitpy: Abstract Executive class : [Attachment 312019] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 172928: webkitpy: Abstract Executive class
https://bugs.webkit.org/show_bug.cgi?id=172928

Attachment 312019: Patch

https://bugs.webkit.org/attachment.cgi?id=312019&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 312019
  --> https://bugs.webkit.org/attachment.cgi?id=312019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312019&action=review

> Tools/Scripts/webkitpy/common/system/abstractexecutive.py:120
> +    def run_command(self,
> +		       args,

Nit: Wrong indentation. Arguments should be indented by exactly 4 spaces.
But I don't think we need to wrap for each argument like this.