[webkit-reviews] review granted: [Bug 170003] [GStreamer] Deadlock in MediaPlayerPrivateGStreamer::changePipelineState, web process often locks up on seeking in a youtube video that has already fully buffered : [Attachment 312005] Updated patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 170003: [GStreamer] Deadlock in
MediaPlayerPrivateGStreamer::changePipelineState, web process often locks up on
seeking in a youtube video that has already fully buffered
https://bugs.webkit.org/show_bug.cgi?id=170003

Attachment 312005: Updated patch

https://bugs.webkit.org/attachment.cgi?id=312005&action=review




--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312005
  --> https://bugs.webkit.org/attachment.cgi?id=312005
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312005&action=review

I don't understand this code, but Miguel does and I'll trust his review, so
rs=me.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:418
> +	   0, // Only one parameter

You need to change this comment since it's zero parameters