[webkit-reviews] review denied: [Bug 158875] Add flag allow-popups-to-escape-sandbox to iframe sandbox : [Attachment 308278] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 4 10:37:08 PDT 2017
Chris Dumez <cdumez at apple.com> has denied Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 158875: Add flag allow-popups-to-escape-sandbox to iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=158875
Attachment 308278: Patch
https://bugs.webkit.org/attachment.cgi?id=308278&action=review
--- Comment #22 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 308278
--> https://bugs.webkit.org/attachment.cgi?id=308278
Patch
The rest of the change looks good otherwise but I'll r- for now as I think the
logic in Document::canNavigate() can and needs to be simplified.
More information about the webkit-reviews
mailing list