[webkit-reviews] review granted: [Bug 172898] Implement DOMMatrix's fromFloat32Array / fromFloat64Array & toFloat32Array / toFloat64Array : [Attachment 311948] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172898: Implement DOMMatrix's fromFloat32Array / fromFloat64Array &
toFloat32Array / toFloat64Array
https://bugs.webkit.org/show_bug.cgi?id=172898

Attachment 311948: Patch

https://bugs.webkit.org/attachment.cgi?id=311948&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311948
  --> https://bugs.webkit.org/attachment.cgi?id=311948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311948&action=review

> Source/WebCore/css/DOMMatrixReadOnly.idl:97
> +    [NewObject] Float32Array? toFloat32Array();
> +    [NewObject] Float64Array? toFloat64Array();

Perhaps this should throw an out of memory exception rather than making them
nullable?