[webkit-reviews] review requested: [Bug 172729] Fix build of Windows-specific code with ICU 59.1 : [Attachment 311937] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 3 14:37:34 PDT 2017
Konstantin Tokarev <annulen at yandex.ru> has asked for review:
Bug 172729: Fix build of Windows-specific code with ICU 59.1
https://bugs.webkit.org/show_bug.cgi?id=172729
Attachment 311937: Patch
https://bugs.webkit.org/attachment.cgi?id=311937&action=review
--- Comment #14 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 311937
--> https://bugs.webkit.org/attachment.cgi?id=311937
Patch
I haven't managed to remove String::String(UChar*) and
String::charactersWithNullTermination() in this patch, because they are used in
many places that aren't touched in this patch otherwise, however it would be
possible to remove them later.
More information about the webkit-reviews
mailing list