[webkit-reviews] review granted: [Bug 172887] ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html : [Attachment 311895] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 172887: ASSERTION FAILED: m_currentScriptCallbackID in
UIScriptContext::requestUIScriptCompletion(JSStringRef) running
fast/events/ios/autocorrect-with-range-selection.html
https://bugs.webkit.org/show_bug.cgi?id=172887

Attachment 311895: Patch

https://bugs.webkit.org/attachment.cgi?id=311895&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311895
  --> https://bugs.webkit.org/attachment.cgi?id=311895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311895&action=review

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:487
> +	   // applyAutocorrection can call its completion handler
synchronously,
> +	   // which makes UIScriptController unhappy (see bug 172884).

Should we change applyAutocorrection? Are we consistent about whether
completionHandlers can call back synchronously?