[webkit-reviews] review granted: [Bug 172896] Implement DOMPointReadOnly.matrixTransform() : [Attachment 311940] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 172896: Implement DOMPointReadOnly.matrixTransform()
https://bugs.webkit.org/show_bug.cgi?id=172896

Attachment 311940: Patch

https://bugs.webkit.org/attachment.cgi?id=311940&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 311940
  --> https://bugs.webkit.org/attachment.cgi?id=311940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311940&action=review

r=me

> LayoutTests/imported/w3c/ChangeLog:14
> +	   * web-platform-tests/css/geometry-1/DOMPoint-002.html:

I don't think we should be modifying downstream tests unless the same change
has landed upstream. Also, there is no behavior change here so this downstream
change is not strictly needed.

> LayoutTests/imported/w3c/ChangeLog:16
> +	   * web-platform-tests/css/geometry-1/DOMPoint-003.html: Added.

Ditto, I don't think we should modify this folder unless we are sync'ing with
upstream. We should consider landing this upstream first, and/or put this new
test in LayoutTests/http/wpt/geometry/ in the mean time.