[webkit-reviews] review granted: [Bug 172886] Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp : [Attachment 311906] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 172886: Cleanup arguments to preparePlatformFont() and fontWithFamily() in
FontCacheCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=172886

Attachment 311906: Patch

https://bugs.webkit.org/attachment.cgi?id=311906&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 311906
  --> https://bugs.webkit.org/attachment.cgi?id=311906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review

> Source/WebCore/platform/graphics/FontCache.h:284
> +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&,
const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings*
fontFaceVariantSettings, FontSelectionSpecifiedCapabilities
fontFaceCapabilities, float size);

Here this could be:

RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&,
const FontFeatureSettings*, const FontVariantSettings*,
FontSelectionSpecifiedCapabilities, float size);