[webkit-reviews] review granted: [Bug 172889] Clenaup FrameView::autoSizeIfEnabled. : [Attachment 311899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 2 20:00:20 PDT 2017


Tim Horton <thorton at apple.com> has granted zalan <zalan at apple.com>'s request
for review:
Bug 172889: Clenaup FrameView::autoSizeIfEnabled.
https://bugs.webkit.org/show_bug.cgi?id=172889

Attachment 311899: Patch

https://bugs.webkit.org/attachment.cgi?id=311899&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 311899
  --> https://bugs.webkit.org/attachment.cgi?id=311899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311899&action=review

> Source/WebCore/ChangeLog:3
> +	   Clenaup FrameView::autoSizeIfEnabled.

Useless title, not even spelled right :)

> Source/WebCore/page/FrameView.cpp:3746
> +    // FIXME: Now that autoSizeIfEnabled() actually returns clean, we don't
need to call it from layout() anymore.

Don't know if this is a useful comment. Especially if not attached to a bug
that explains why we might want to move it elsewhere.


More information about the webkit-reviews mailing list