[webkit-reviews] review granted: [Bug 172876] webkitpy: Add contextmanager to disable logging for a block : [Attachment 311886] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 172876: webkitpy: Add contextmanager to disable logging for a block
https://bugs.webkit.org/show_bug.cgi?id=172876

Attachment 311886: Patch

https://bugs.webkit.org/attachment.cgi?id=311886&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 311886
  --> https://bugs.webkit.org/attachment.cgi?id=311886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311886&action=review

> Tools/Scripts/webkitpy/common/system/outputcapture.py:114
> +	   self.captured_output = None

This should return (None, None, None) to match up with how restore_output()
behaves.

> Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py:61
> +    def test_output_capture_scope(self):

Please add a test where OutputScope takes an OutputCapture as an argument.