[webkit-reviews] review granted: [Bug 172737] REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text" accessibility setting is enabled : [Attachment 311856] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 172737: REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text"
accessibility setting is enabled
https://bugs.webkit.org/show_bug.cgi?id=172737

Attachment 311856: Patch

https://bugs.webkit.org/attachment.cgi?id=311856&action=review




--- Comment #22 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 311856
  --> https://bugs.webkit.org/attachment.cgi?id=311856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311856&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1219
> +    static float weightThresholds[] = { -0.6, -0.365, -0.115, 0.130, 0.235,
0.350, 0.5, 0.7 };

I'd like to see a comment saying where these magic numbers come from.

> Source/WebCore/testing/InternalSettings.cpp:690
> +   
RenderTheme::singleton().setShouldMockBoldSystemFontForAccessibility(requires);
> +   
FontCache::singleton().setShouldMockBoldSystemFontForAccessibility(requires);

Feels slightly weird to stash this state in two places.