[webkit-reviews] review granted: [Bug 172844] Atomics.load and Atomics.store need to be fully fenced : [Attachment 311831] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 2 10:51:03 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 172844: Atomics.load and Atomics.store need to be fully fenced
https://bugs.webkit.org/show_bug.cgi?id=172844

Attachment 311831: the patch

https://bugs.webkit.org/attachment.cgi?id=311831&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 311831
  --> https://bugs.webkit.org/attachment.cgi?id=311831
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311831&action=review

r=me.

> Source/JavaScriptCore/ftl/FTLOutput.h:380
> +    LValue atomicWeakCAS(LValue expected, LValue newValue, TypedPointer
pointer, B3::Width);

Do you use this?


More information about the webkit-reviews mailing list