[webkit-reviews] review granted: [Bug 172858] [MediaStream iOS] Cleanup video muting/unmuting when tab visibility changes : [Attachment 311827] Proposed patch.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 172858: [MediaStream iOS] Cleanup video muting/unmuting when tab visibility
changes
https://bugs.webkit.org/show_bug.cgi?id=172858

Attachment 311827: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=311827&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 311827
  --> https://bugs.webkit.org/attachment.cgi?id=311827
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=311827&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:337
> +void RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility(bool
muted)

shouldMute instead of muted?

> LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html:67
> +

Double space line