[webkit-reviews] review granted: [Bug 172564] Web Inspector: Web Sockets: Do not update DataGrid when it is not visible : [Attachment 311171] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 172564: Web Inspector: Web Sockets: Do not update DataGrid when it is not
visible
https://bugs.webkit.org/show_bug.cgi?id=172564

Attachment 311171: Patch

https://bugs.webkit.org/attachment.cgi?id=311171&action=review




--- Comment #7 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 311171
  --> https://bugs.webkit.org/attachment.cgi?id=311171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311171&action=review

> Source/WebInspectorUI/UserInterface/Views/NetworkTimelineDataGrid.js:26
> +WebInspector.NetworkTimelineDataGrid = class NetworkTimelineDataGrid extends
WebInspector.TimelineDataGrid

Why not just bake this into TimelineDataGrid and have it apply to all
Timelines? Seems like an optimization that would benefit all of them.