[webkit-reviews] review granted: [Bug 172857] [GCrypt] Fix PK verification for ECDSA : [Attachment 311823] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172857: [GCrypt] Fix PK verification for ECDSA
https://bugs.webkit.org/show_bug.cgi?id=172857

Attachment 311823: Patch

https://bugs.webkit.org/attachment.cgi?id=311823&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 311823
  --> https://bugs.webkit.org/attachment.cgi?id=311823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311823&action=review

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:226
> +    // a failure in any other case. OperationError should not be returned at
this point.

The comment should explain *why* OperationError should not be returned at this
point: to avoid spilling information about the exact cause of verification
failure.