[webkit-reviews] review granted: [Bug 172836] [css-grid] Logical margin incorrectly applied during the tracks sizing algorithm of auto tracks : [Attachment 311765] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 2 01:04:35 PDT 2017


Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 172836: [css-grid] Logical margin incorrectly applied during the tracks
sizing algorithm of auto tracks
https://bugs.webkit.org/show_bug.cgi?id=172836

Attachment 311765: Patch

https://bugs.webkit.org/attachment.cgi?id=311765&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 311765
  --> https://bugs.webkit.org/attachment.cgi?id=311765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311765&action=review

>
LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-
flows.html:7
> +.item { margin: 10px 5px 5px 15px; }

I'd use a different value for each margin property, so we're sure we're not
mixing margin-right and margin-bottom.
What about something like: 10px 5px 20px 15px ?


More information about the webkit-reviews mailing list