[webkit-reviews] review denied: [Bug 172737] REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text" accessibility setting is enabled : [Attachment 311786] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 172737: REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text"
accessibility setting is enabled
https://bugs.webkit.org/show_bug.cgi?id=172737

Attachment 311786: Patch

https://bugs.webkit.org/attachment.cgi?id=311786&action=review




--- Comment #15 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 311786
  --> https://bugs.webkit.org/attachment.cgi?id=311786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311786&action=review

>>
Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:156
>> +		atexit(&WebKit::unBoldSystemFontForAccessibility);
> 
> This part is gross and I think we should try to avoid it.

Agreed, I think we need an alternate solution here. Why is this atexit()
needed? Your changelog did not say.