[webkit-reviews] review denied: [Bug 172841] Fix MotionMark to work in Internet Explorer : [Attachment 311796] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 1 19:55:09 PDT 2017


Jon Lee <jonlee at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 172841: Fix MotionMark to work in Internet Explorer
https://bugs.webkit.org/show_bug.cgi?id=172841

Attachment 311796: Patch

https://bugs.webkit.org/attachment.cgi?id=311796&action=review




--- Comment #4 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 311796
  --> https://bugs.webkit.org/attachment.cgi?id=311796
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311796&action=review

> PerformanceTests/MotionMark/resources/extensions.js:237
> +    this.parentNode.removeChild(this);

This is wrong. We should only set this for UA’s that do not have the method
defined.


More information about the webkit-reviews mailing list