[webkit-reviews] review granted: [Bug 172833] [JSCOnly] Build static jsc.exe on Windows : [Attachment 311770] Updated patch for static jsc.exe jsconly build on Windows with less cruft

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 172833: [JSCOnly] Build static jsc.exe on Windows
https://bugs.webkit.org/show_bug.cgi?id=172833

Attachment 311770: Updated patch for static jsc.exe jsconly build on Windows
with less cruft

https://bugs.webkit.org/attachment.cgi?id=311770&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 311770
  --> https://bugs.webkit.org/attachment.cgi?id=311770
Updated patch for static jsc.exe jsconly build on Windows with less cruft

View in context: https://bugs.webkit.org/attachment.cgi?id=311770&action=review

r=me with comments.

> Source/WTF/wtf/PlatformJSCOnly.cmake:60
> +    list(APPEND WTF_LIBRARIES
> +	   winmm
> +    )

Could you move these lines inside `if (WIN32)` in L20-24?

> Source/cmake/OptionsJSCOnly.cmake:48
> +# FIXME: JSCOnly on WIN32 seems to only work with fully static build

Could you open a bug for this FIXME and add URL here?

> Tools/CMakeLists.txt:31
> +elseif ("${PORT}" STREQUAL "Win")

Nice.