[webkit-reviews] review granted: [Bug 172832] [Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest : [Attachment 311756] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 172832: [Cocoa] Add a "supportedCountries" property to
ApplePayPaymentRequest
https://bugs.webkit.org/show_bug.cgi?id=172832

Attachment 311756: Patch

https://bugs.webkit.org/attachment.cgi?id=311756&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 311756
  --> https://bugs.webkit.org/attachment.cgi?id=311756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311756&action=review

> Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h:61
> +    std::optional<Vector<String>> supportedCountries;

I'm not sure the difference between nullopt and an empty vector is important
enough to make this an optional vector.

> LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:23
> +SETUP: request = validRequest(); request.supportedCountries = 7;
> +PASS new ApplePaySession(3, request) threw exception TypeError: Value is not
a sequence.

Let's add a test that contains a valid sequence that contains things that are
not strings.  Also an empty sequence.