[webkit-reviews] review granted: [Bug 172797] Make WebCore::defaultPortForProtocol() thread-safe : [Attachment 311748] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 172797: Make WebCore::defaultPortForProtocol() thread-safe
https://bugs.webkit.org/show_bug.cgi?id=172797

Attachment 311748: Patch

https://bugs.webkit.org/attachment.cgi?id=311748&action=review




--- Comment #11 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 311748
  --> https://bugs.webkit.org/attachment.cgi?id=311748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311748&action=review

r=me

> Source/WebCore/platform/URL.cpp:547
> +static Lock& defaultPortForProtocolMapLock()

Maybe call this "defaultPortForProtocolMapForTestingLock" to match the other
methods?

> Source/WebCore/platform/URL.cpp:556
> +    static DefaultPortForProtocolMapForTesting* defaultPortForProtocolMap;

Do we need to initialize this to nullptr?