[webkit-reviews] review canceled: [Bug 172822] We don't invalidate descendants when the matching status of a ::slotted selector changes. : [Attachment 311730] Patch

[bugzilla-daemon at webkit.org]

Emilio Cobos Álvarez <ecobos at igalia.com> has canceled Emilio Cobos Álvarez
<ecobos at igalia.com>'s request for review:
Bug 172822: We don't invalidate descendants when the matching status of a
::slotted selector changes.
https://bugs.webkit.org/show_bug.cgi?id=172822

Attachment 311730: Patch

https://bugs.webkit.org/attachment.cgi?id=311730&action=review




--- Comment #3 from Emilio Cobos Álvarez <ecobos at igalia.com> ---
Comment on attachment 311730
  --> https://bugs.webkit.org/attachment.cgi?id=311730
Patch

Gah, this is not going to be enough... I verified that the bug is fixed if I
use is<HTMLSlotElement>, and assumed that shadowRoot() would return non-null
for an attached slot (which isn't true).

But to properly handle descendant combinators I need to check if an element is
a slot, or an ancestor of a slot...

Is (shadowRoot || is<HTMLSlotElement>(element)) the correct check for that?