[webkit-reviews] review granted: [Bug 172780] [WebCore] Enable REQUEST_ANIMATION_FRAME_TIMER for all ports : [Attachment 311666] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 1 09:34:15 PDT 2017
Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at am.sony.com>'s request for review:
Bug 172780: [WebCore] Enable REQUEST_ANIMATION_FRAME_TIMER for all ports
https://bugs.webkit.org/show_bug.cgi?id=172780
Attachment 311666: Patch
https://bugs.webkit.org/attachment.cgi?id=311666&action=review
--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 311666
--> https://bugs.webkit.org/attachment.cgi?id=311666
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=311666&action=review
> Source/WebCore/page/Chrome.h:88
> - void scheduleAnimation() override;
> + void scheduleAnimation() override { }
Yeah, this seems no longer needed, so let's just remove it. Maybe in a
followup patch if that requires more surgery.
And if it is needed and can be final instead of just override, let's do that.
More information about the webkit-reviews
mailing list