[webkit-reviews] review granted: [Bug 172783] [css-grid] Update W3C web platform tests for the CSS Grid Layout feature : [Attachment 311662] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 1 00:49:11 PDT 2017


Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 172783: [css-grid] Update W3C web platform tests for the CSS Grid Layout
feature
https://bugs.webkit.org/show_bug.cgi?id=172783

Attachment 311662: Patch

https://bugs.webkit.org/attachment.cgi?id=311662&action=review




--- Comment #6 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 311662
  --> https://bugs.webkit.org/attachment.cgi?id=311662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311662&action=review

Thanks for doing this.

> LayoutTests/imported/w3c/ChangeLog:8
> +	   Imported the last CSS Grid Layout web platform tests.

It's nice to refer to the git commit that we're importing from WPT for future
reference.

For example like we do in: https://bugs.webkit.org/show_bug.cgi?id=172494

> LayoutTests/imported/w3c/resources/import-expectations.json:298
> +}

I guess this change was automatically done by the importer script.


More information about the webkit-reviews mailing list