[webkit-reviews] review granted: [Bug 174987] Web Automation: add event to notify service when a page's main frame window object has cleared : [Attachment 316796] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 174987: Web Automation: add event to notify service when a page's main
frame window object has cleared
https://bugs.webkit.org/show_bug.cgi?id=174987

Attachment 316796: Patch

https://bugs.webkit.org/attachment.cgi?id=316796&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 316796
  --> https://bugs.webkit.org/attachment.cgi?id=316796
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316796&action=review

LGTM, do we need a WebKit2 owner approval for this?

> Source/WebKit/UIProcess/Automation/Automation.json:530
> +	   {
> +	       "name": "browsingContextCleared",
> +	       "description": "Fired when the specified browsing context has
navigated or closed. Existing element references from the browsing context are
no longer valid.",
> +	       "parameters": [
> +		   { "name": "browsingContextHandle", "$ref":
"BrowsingContextHandle" }
> +	       ]

What does safaridriver do in response to this? element references are in the
automation proxy in the web process, no? or does safaridriver keep also a cache
of element references?