[webkit-reviews] review granted: [Bug 175005] Support quirk for letting media autoplay if the user interacted with at least one media element : [Attachment 316815] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Matt Rajca
<mrajca at apple.com>'s request for review:
Bug 175005: Support quirk for letting media autoplay if the user interacted
with at least one media element
https://bugs.webkit.org/show_bug.cgi?id=175005

Attachment 316815: Patch

https://bugs.webkit.org/attachment.cgi?id=316815&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 316815
  --> https://bugs.webkit.org/attachment.cgi?id=316815
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316815&action=review

> Source/WebCore/ChangeLog:5
> +

Radar?

> Source/WebCore/html/MediaElementSession.cpp:194
> +    if (needsDocumentLevelMediaUserGestureQuirk(element.document()) &&
element.document().topDocument().mediaState() &
MediaProducer::HasUserInteractedWithMediaElement)

Nit: may be worth swapping the order of the comparisons.