[webkit-reviews] review denied: [Bug 174477] Created Individual EWS Pages : [Attachment 315961] Reverted the changes to urls.py and bugzilla.py
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 31 14:25:57 PDT 2017
Aakash Jain <aakash_jain at apple.com> has denied obinna obike
<oobike at apple.com>'s request for review:
Bug 174477: Created Individual EWS Pages
https://bugs.webkit.org/show_bug.cgi?id=174477
Attachment 315961: Reverted the changes to urls.py and bugzilla.py
https://bugs.webkit.org/attachment.cgi?id=315961&action=review
--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 315961
--> https://bugs.webkit.org/attachment.cgi?id=315961
Reverted the changes to urls.py and bugzilla.py
View in context: https://bugs.webkit.org/attachment.cgi?id=315961&action=review
> Tools/ChangeLog:7
> +
Please describe your changes in the ChangeLog. Please see
https://webkit.org/contributing-code/#changelog-files
> Tools/QueueStatusServer/handlers/patch.py:50
> + per_queue_statuses = queue_status.get(status.queue_name,
[])
As I requested couple of times in-person, please avoid this code duplication.
It's a simple if else, you should be able to avoid the duplication.
> Tools/QueueStatusServer/handlers/statusbubble.py:91
> + message = "\n\nhttps://build.webkit.org/dashboard/"
This is completely unrelated change. Please remove this change from this patch
and create a separate bug for this change. Make sure you test it as well.
More information about the webkit-reviews
mailing list