[webkit-reviews] review granted: [Bug 174863] WebDriver: use in-view center point for clicks instead of bounding box center point : [Attachment 316772] Try to fix mac builds

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174863: WebDriver: use in-view center point for clicks instead of bounding
box center point
https://bugs.webkit.org/show_bug.cgi?id=174863

Attachment 316772: Try to fix mac builds

https://bugs.webkit.org/attachment.cgi?id=316772&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316772
  --> https://bugs.webkit.org/attachment.cgi?id=316772
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=316772&action=review

r=me

Does this progress any Selenium python tests?

> Source/WebDriver/Session.cpp:1043
> +	   if (!inViewCenter) {

Very nice!

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:477
> +    // §11.1 Element Interactability.

Very nice.