[webkit-reviews] review granted: [Bug 130653] Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout : [Attachment 316750] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 130653: Remove code in HTMLObjectElement attribute parsing that forces
style resolution and layout
https://bugs.webkit.org/show_bug.cgi?id=130653

Attachment 316750: Patch

https://bugs.webkit.org/attachment.cgi?id=316750&action=review




--- Comment #75 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 316750
  --> https://bugs.webkit.org/attachment.cgi?id=316750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316750&action=review

r=me, nice

> Source/WebCore/dom/Document.cpp:6228
> +    // FIXME: Should the call to FrameLoader::checkLoadComplete be moved
inside Document::checkCompleted?
> +    // FIXME: Should this also call DocumentLoader::checkLoadComplete?
> +    // FIXME: Not obvious why checkCompleted needs to go first. The order
these are called is
> +    // visible to WebKit clients, but it's more like a race than a
well-defined relationship.

This logic should be cleaned up at some point. It feels as if the original
intent of the differnt check/loadCompleted/isLoading functions has been lost at
some point and they are now being called without rhyme or reason.