[webkit-reviews] review requested: [Bug 174777] Update Bot Watcher's Dashboard for buildbot 0.9 : [Attachment 316686] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 28 17:36:02 PDT 2017


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 174777: Update Bot Watcher's Dashboard for buildbot 0.9
https://bugs.webkit.org/show_bug.cgi?id=174777

Attachment 316686: Updated patch

https://bugs.webkit.org/attachment.cgi?id=316686&action=review




--- Comment #10 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 316686

  --> https://bugs.webkit.org/attachment.cgi?id=316686&action=review

Updated patch

Incorporated the review comments.

> How did you come to pick the first build? Or is data.builds a misnomer and it
should be renamed data.build that represents a single build?
Yes, data.builds represents a single build here (since we fetched info for only
one specific build in this class). Buildbot has this weird way of referring
everything as a plural, even though it is singular. See:
https://docs.buildbot.net/0.9.0/developer/rest.html#collections


More information about the webkit-reviews mailing list