[webkit-reviews] review granted: [Bug 174947] Don't add autoplay restrictions to media elements created in response to user gestures : [Attachment 316665] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Matt Rajca
<mrajca at apple.com>'s request for review:
Bug 174947: Don't add autoplay restrictions to media elements created in
response to user gestures
https://bugs.webkit.org/show_bug.cgi?id=174947

Attachment 316665: Patch

https://bugs.webkit.org/attachment.cgi?id=316665&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 316665
  --> https://bugs.webkit.org/attachment.cgi?id=316665
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316665&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:466
> +	   const bool isProcessingUserGesture =
processingUserGestureForMedia();

Why const for this and not the other bool variables?

> LayoutTests/media/video-create-with-user-gesture.html:17
> +	   failTestIn(1000);

Nit: this is probably too short for a heavily laden machine (e.g. a bot). I
would set it to something like 10 seconds.