[webkit-reviews] review granted: [Bug 174885] [macOS] Reeder's defaults font is Times instead of San Francisco : [Attachment 316648] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 174885: [macOS] Reeder's defaults font is Times instead of San Francisco
https://bugs.webkit.org/show_bug.cgi?id=174885

Attachment 316648: Patch

https://bugs.webkit.org/attachment.cgi?id=316648&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316648
  --> https://bugs.webkit.org/attachment.cgi?id=316648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316648&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:163
> +    if (family1.startsWith('.'))
> +	   return StringHash::equal(family1.string(), family2.string());
> +    return ASCIICaseInsensitiveHash::equal(family1, family2);

Please add a comment here with a radar number that references the underlying
reason why dot names have to be case sensitive.

> Source/WebCore/platform/graphics/FontDescription.cpp:170
> +    if (family.startsWith('.'))
> +	   return StringHash::hash(family.string());
> +    return ASCIICaseInsensitiveHash::hash(family);

And here.

> Source/WebCore/platform/graphics/FontDescription.cpp:177
> +    if (family.startsWith('.'))
> +	   return family.string();
> +    return family.string().foldCase();

And here.