[webkit-reviews] review requested: [Bug 174930] Using "auto <function()> -> returnType" breaks prepare-ChangeLog : [Attachment 316644] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 28 09:40:48 PDT 2017


JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 174930: Using "auto <function()> -> returnType" breaks prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=174930

Attachment 316644: patch

https://bugs.webkit.org/attachment.cgi?id=316644&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Created attachment 316644

  --> https://bugs.webkit.org/attachment.cgi?id=316644&action=review

patch

(In reply to Daniel Bates from comment #2)
> We have unit tests for this code. Please add a unit test to

"unit tests"? What are those? ;-)

While I'm here, I also added const and volatile overloads.


More information about the webkit-reviews mailing list