[webkit-reviews] review granted: [Bug 174813] [WinCairo] Implement Font::platformBoundsForGlyph : [Attachment 316514] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 28 08:30:00 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 174813: [WinCairo] Implement Font::platformBoundsForGlyph
https://bugs.webkit.org/show_bug.cgi?id=174813

Attachment 316514: Patch

https://bugs.webkit.org/attachment.cgi?id=316514&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 316514
  --> https://bugs.webkit.org/attachment.cgi?id=316514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316514&action=review

> Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:114
> +    SaveDC(dc);

Would it be more efficient to use GetCurrentObject and GetGraphicsMode instead
of saving the entire dc?


More information about the webkit-reviews mailing list