[webkit-reviews] review granted: [Bug 174928] [iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down : [Attachment 316621] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174928: [iOS DnD] [WK1] Snapshots generated using -[DOMRange
renderImageForcingBlackText:] are upside down
https://bugs.webkit.org/show_bug.cgi?id=174928

Attachment 316621: Patch

https://bugs.webkit.org/attachment.cgi?id=316621&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 316621
  --> https://bugs.webkit.org/attachment.cgi?id=316621
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316621&action=review

> Source/WebCore/ChangeLog:25
> +	   Add a FIXME to point out that having an additional context flip
inside the UIGraphicsImageRenderer block results
> +	   in an upside-down drag image being returned from
createDragImageFromImage. This image is being flipped elsewhere
> +	   in drag initiation code, which eventually results in the correct
orientation; we'll need further investigation
> +	   to remove this extraneous flip.

The DragImage code is full of flips in odd places.