[webkit-reviews] review requested: [Bug 174777] Update Bot Watcher's Dashboard for buildbot 0.9 : [Attachment 316594] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 27 18:47:34 PDT 2017
Aakash Jain <aakash_jain at apple.com> has asked for review:
Bug 174777: Update Bot Watcher's Dashboard for buildbot 0.9
https://bugs.webkit.org/show_bug.cgi?id=174777
Attachment 316594: Updated patch
https://bugs.webkit.org/attachment.cgi?id=316594&action=review
--- Comment #8 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 316594
--> https://bugs.webkit.org/attachment.cgi?id=316594&action=review
Updated patch
Incorporated Dan Bates feedback.
Simplified the use of 'id' variable in BuildbotQueue.js. Earlier 'id' for each
queue was being modified by Buildbot.js after slight delay (after doing a REST
API call). Now, Buildbot.js does not modify the 'id' at all, the fetched
information is only used inside Buildbot.js.
Tested with buildbot 0.8 and 0.9.
More information about the webkit-reviews
mailing list