[webkit-reviews] review granted: [Bug 174880] Part 2 of: Rename DatabaseProcess to StorageProcess : [Attachment 316581] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 27 16:57:12 PDT 2017


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 174880: Part 2 of: Rename DatabaseProcess to StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=174880

Attachment 316581: Patch

https://bugs.webkit.org/attachment.cgi?id=316581&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 316581
  --> https://bugs.webkit.org/attachment.cgi?id=316581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316581&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:315
> -void
NetworkProcess::didGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t
requestID)
> +void
NetworkProcess::didgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t
requestID)

Lower-case g doesn't look right.

> Source/WebKit/NetworkProcess/NetworkProcess.h:200
> -    void didGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t
requestID);
> +    void didgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t
requestID);

Ditto.

> Source/WebKit/NetworkProcess/NetworkProcess.messages.in:83
> -    DidGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t requestID)
> +    DidgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t requestID)

Ditto.


More information about the webkit-reviews mailing list